I looked at my three older kids and could see they are still babies at a year. And I was not about to just stop doing something that brought them great comfort and happiness just because they were 12 months old.
I'll tell you this, though, BFing at the breast is MUCH easier than pumping and giving milk that way. And even more so when you have a toddler. A toddler might need to just nurse for a minute or two for comfort and gets health benefits in the process, but if you offer milk in a cup, you are taking away the comfort aspect, tying yourself up for 15-30 minutes to pump that milk...that they might not finish!
I nursed all of mine until they were almost two. They self-weaned because I was pregnant again and lost my supply. The third one last nursed on Thanksgiving day.
As soon as they stop nursing, the constant colds begin and the ability to resolve a tantrum easily ends